[U-Boot] [PATCH] driver/mxc_i2c: Move static data structure to global_data

[York Sun]

On 02/11/2014 02:12 PM, Wolfgang Denk wrote:
> Dear York,
> 
> In message <52FA8FDB.3030808 at freescale.com> you wrote:
>>
>>> well, to do something with the linker script, you need some memory
>>> somewhere you can use for this purpose.  Your example showed SRAM. so
>>> if you do have SRAM on that board - why do you not use it for stack
>>> and GD?  Where is your steck and GD right now?
>>
>> The initial stack and GD are in SRAM. Of course they are moved to SDRAM after
>> initialization. I intend to spare SRAM for other purpose after relocation.
> 
> Well, after relocation GD has also been relocated, so your SRAM would
> be comletely unused.

Sounds like you are OK with using GD for this patch. Let's wait to hear from
Tom. He nacked this idea.

> 
>> I am scratching my head trying to figure out how to put this variable "srdata"
>> in mxc_i2c.c into stack. Please give me some guidance if you have the idea on
>> top of your head.
> 
> I have no idea which code you are talking about - sorry.
> 

http://patchwork.ozlabs.org/patch/319073/


-/*
- * For SPL boot some boards need i2c before SDRAM is initialized so force
- * variables to live in SRAM
- */
-static struct sram_data __attribute__((section(".data"))) srdata;
-

I moved this variable into GD. Is there a alternative way to do it? I tried to
use stack but didn't find the solution.

York