[U-Boot] [PATCH] driver/mxc_i2c: Move static data structure to global_data

Tom Rini trini at ti.com
Wed Feb 12 15:43:47 CET 2014


On Wed, Feb 12, 2014 at 03:27:58PM +0100, Wolfgang Denk wrote:
> Dear York,
> 
> In message <52FAA233.6090403 at freescale.com> you wrote:
> >
> > > Well, after relocation GD has also been relocated, so your SRAM would
> > > be comletely unused.
> > 
> > Sounds like you are OK with using GD for this patch. Let's wait to hear from
> > Tom. He nacked this idea.
> 
> I don't say I think this is a good change.  I just tried to explain to
> you that the SRAM will be unused after relocation completed.  Tom
> probably has the same problem as I: I cannot understand why you are
> changing the code.  If it's been working as is before, then why would
> it stop now?

I think I see it.  We had been concerned with the SPL case, and the
current driver work-around is how we do it (as to not litter gd->arch
with lots of things just for drivers we need so very very early in SPL).
York now has a different setup where this i2c block is being reused,
where SRAM is big enough (apparently) to load the whole of U-Boot into
and start execution from, but we still want to relocate into DDR.  This
is a problem over in TI-land we've avoided by simply saying "lets keep
using SPL anyhow".

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140212/1d0e2d0a/attachment.pgp>


More information about the U-Boot mailing list