[U-Boot] [PATCH 2/3] board/snowball: Add support for network boot
Albert ARIBAUD
albert.u.boot at aribaud.net
Thu Feb 13 10:29:15 CET 2014
Hi Roy,
On Fri, 20 Dec 2013 13:32:35 +0100, Roy Spliet <rspliet at eclipso.eu>
wrote:
> Signed-off-by: Roy Spliet <rspliet at eclipso.eu>
> ---
> board/st-ericsson/snowball/snowball.c | 11 +++++++++++
> include/configs/snowball.h | 14 ++++++++++++++
> 2 files changed, 25 insertions(+)
>
> diff --git a/board/st-ericsson/snowball/snowball.c b/board/st-ericsson/snowball/snowball.c
> index c3061e2..c9ab71f 100644
> --- a/board/st-ericsson/snowball/snowball.c
> +++ b/board/st-ericsson/snowball/snowball.c
> @@ -245,6 +245,8 @@ int board_late_init(void)
> while (tstc())
> (void) getc();
>
> + mdelay(25);
Please explain (here at least, possible also in commit depending on the
reason) why a 25 ms delay is needed -- and why it was not needed before.
> +
> return 0;
> }
>
> @@ -338,3 +340,12 @@ int board_mmc_init(bd_t *bis)
> return 0;
> }
> #endif /* CONFIG_MMC */
> +
> +int board_eth_init(bd_t *bis)
> +{
> + int error = smc911x_initialize(0, CONFIG_SMC911X_BASE);
> + if (error)
> + return error;
> +
> + return cpu_eth_init(bis);
> +}
> diff --git a/include/configs/snowball.h b/include/configs/snowball.h
> index 9a069f3..6201b3f 100644
> --- a/include/configs/snowball.h
> +++ b/include/configs/snowball.h
> @@ -95,6 +95,10 @@
> #define CONFIG_CMD_FAT
> #define CONFIG_CMD_EXT2
> #define CONFIG_CMD_SOURCE
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_NET
> +#define CONFIG_CMD_NFS
> +#define CONFIG_CMD_PING
>
> #ifndef CONFIG_BOOTDELAY
> #define CONFIG_BOOTDELAY 1
> @@ -245,4 +249,14 @@
>
> #define CFG_FSMC_BASE 0x80000000 /* FSMC Controller */
>
> +/*
> + * Networking
> + */
> +#define CONFIG_NET
> +#define CONFIG_NET_MULTI
> +#define CONFIG_SMC911X
> +#define CONFIG_SMC911X_16_BIT
> +#define CONFIG_SMC911X_SHIFT 1
> +#define CONFIG_SMC911X_BASE 0x50000000
> +
> #endif /* __CONFIG_H */
Amicalement,
--
Albert.
More information about the U-Boot
mailing list