[U-Boot] [PATCH 1/8] arm/km: drop unneeded define

Albert ARIBAUD albert.u.boot at aribaud.net
Thu Feb 13 13:06:10 CET 2014


Hi Holger,

For the whole series: shouldn't the keymile boards maintainer be CC:ed?

On Mon, 27 Jan 2014 16:58:22 +0100, Holger Brunck
<holger.brunck at keymile.com> wrote:

> CONFIG_BOOTCOUNT_LIMIT is used on all boards from this board series. So
> remove this unneeded define.

What if a new board/config does not want to use a bootcount limit?

> Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> ---
>  board/keymile/km_arm/km_arm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c
> index 5620737..946cbed 100644
> --- a/board/keymile/km_arm/km_arm.c
> +++ b/board/keymile/km_arm/km_arm.c
> @@ -164,7 +164,6 @@ static int initialize_unit_leds(void)
>  	return 0;
>  }
>  
> -#if defined(CONFIG_BOOTCOUNT_LIMIT)
>  static void set_bootcount_addr(void)
>  {
>  	uchar buf[32];
> @@ -173,7 +172,6 @@ static void set_bootcount_addr(void)
>  	sprintf((char *)buf, "0x%x", bootcountaddr);
>  	setenv("bootcountaddr", (char *)buf);
>  }
> -#endif
>  
>  int misc_init_r(void)
>  {
> @@ -210,9 +208,7 @@ int misc_init_r(void)
>  
>  	initialize_unit_leds();
>  	set_km_env();
> -#if defined(CONFIG_BOOTCOUNT_LIMIT)
>  	set_bootcount_addr();
> -#endif
>  	return 0;
>  }
>  


Amicalement,
-- 
Albert.


More information about the U-Boot mailing list