[U-Boot] [PATCH] dts: re-write dts/Makefile more simply with Kbuild

[Simon Glass]

Hi Masahiro,

On 4 February 2014 03:00, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> Hello Simon,
>
>
> I saw the patch you posted
> http://patchwork.ozlabs.org/patch/315846/
> and I understood what you want to do.
> (But I don't like to search similar device trees
> with file name prefixes.)
>
> Do you like ARM Linux style?
>   dtb-$(CONFIG_EXYNOS5) += exynos5250-arndale.dtb \
>         exynos5250-snow.dtb \
>         exynos5250-smdk5250.dtb \
>         exynos5420-smdk5420.dtb
>
> Please check v2.

Agreed, I don't like the prefix idea either.

>
>
>> I think we should still generate this file in the root directory,
>> since some build systems will need to use it.
>
> I vote for removal of ./u-boot.dts
> because I do not want to have many copies.

u-boot.dtb you mean?

>
> If we adopt multiple DTBs generation, we will have three copies:
>   - arch/arm/dts/exynosXXX.dtb

This is the correct one

>   - dts/dt.dtb

This is a temporary file, probably deleted during the build. I'm not
even sure if it is created when you are building multiple files.
Perhaps it use just used for CONFIG_OF_EMBED?

>   - ./u-boot.dtb
>
> But, if you really need a DTB at the top directory,
> I can revive u-boot.dtb at version 3.

For now I think there is a 'default' .dtb for each board config. After
all U-Boot does not have a way to select between several of them at
runtime. So it makes sense for this one to be made available as it
currently is I think. Perhaps it could be a symlink to the real one?

>
>
>> > --- a/arch/arm/lib/board.c
>> > +++ b/arch/arm/lib/board.c
>> > @@ -280,7 +280,7 @@ void board_init_f(ulong bootflag)
>> >         gd->mon_len = _bss_end_ofs;
>> >  #ifdef CONFIG_OF_EMBED
>> >         /* Get a pointer to the FDT */
>> > -       gd->fdt_blob = _binary_dt_dtb_start;
>> > +       gd->fdt_blob = __dtb_db_begin
>>
>> Needs ; on the end I think.
>>
>
> Good catch!
> I fixed it at v2. Thanks.
>
>
>
> Best Regards
> Masahiro Yamada
>

Regards,
Simon