[U-Boot] [PATCH 1/5] wandboard: Staticize usdhc1_pads

Stefano Babic sbabic at denx.de
Sun Feb 16 13:15:43 CET 2014


Hi Fabio,

On 15/02/2014 17:51, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> Fix the following sparse warning:
> 
> wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  board/wandboard/wandboard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
> index 72e9bb2..dbced1c 100644
> --- a/board/wandboard/wandboard.c
> +++ b/board/wandboard/wandboard.c
> @@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = {
>  	MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
>  };
>  
> -iomux_v3_cfg_t const usdhc1_pads[] = {
> +static iomux_v3_cfg_t const usdhc1_pads[] = {
>  	MX6_PAD_SD1_CLK__SD1_CLK   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD1_CMD__SD1_CMD   | MUX_PAD_CTRL(USDHC_PAD_CTRL),
>  	MX6_PAD_SD1_DAT0__SD1_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),

Thanks for fix it. However, which gcc version reports these warnings ?
Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I
saw no error.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list