[U-Boot] [PATCH v2 0/7] usb: eth: introduce Moschip MCS7830 driver

Gerhard Sittig gsi at denx.de
Mon Feb 17 20:35:20 CET 2014


this series
- does a little cleanup: BIT() and BITMASK() macros in common.h,
  no #ifdef for routine declarations in header files
- adds a new USB ethernet driver for adapters that are based on the
  MCS7730/7830/7832 chips
- enables the driver for those boards which previously had support for
  "all other" USB ethernet adapters
- updates the README.usb documentation file to list all available
  drivers for USB ethernet adapters

development and tests were done on a taskit stamp9g20 with Delock and
Logilink adapters, running TFTP transfers of a file as large as RAM is

there are several checkpatch warnings
- about CamelCase for NetReceive() and USB related structure members,
  which cannot get fixed as the names are in the established API
- about a multiple assignment for the "found" flags in the USB endpoint
  search, which I consider acceptable

version v2 addresses all received feedback:
- adjust the Cc: list (network custodian, BIT() macro committers,
  board maintainers)
- move the BIT() macro to the common.h header file
- reduce the number of timeouts, only "USB call" and "network
  link status" timeouts are left
- use errno.h codes instead of the unhelpful "-1" magic number
- factor out common PHY access code, fix the retry logic
- more straight forward init() callback and link status check,
  silent operation according to the U-Boot philosophy
- remove text fold markers
- kernel nano-doc style comments for data structures, global
  variables, and routines
- remove #ifdef from function prototypes in header files
- whitespace fixes (in the USB dongle list comments)
- switch the USB dongle list from sentinel terminated to "dense,
  useful data only" and iterate by means of ARRAY_SIZE()
- remove an ugly and non-obvious "unused" silencer, instead
  use the __maybe_unused decoration near the implementation

Gerhard Sittig (7):
  include: move the BIT() macro into the common.h header file
  usb: eth: don't ifdef routine declarations in usb_ether.h
  usb: eth: introduce support for Moschip USB ethernet
  config: alpha-sort USB ethernet items for Asix and SMSC
  config: enable Moschip USB ethernet support for several boards
  config: enable USB ethernet for taskit stamp9g20
  usb: doc: update README.usb to list all USB ethernet options

 arch/arm/cpu/arm1176/tnetv107x/clock.c   |    2 -
 arch/arm/cpu/arm926ejs/davinci/cpu.c     |    2 -
 arch/arm/include/asm/arch-am33xx/cpu.h   |    3 +-
 arch/arm/include/asm/arch-ixp/ixp425.h   |    2 +-
 arch/arm/include/asm/arch-omap5/cpu.h    |    4 +-
 arch/arm/include/asm/arch-tegra20/dc.h   |    4 +-
 doc/README.usb                           |   13 +-
 drivers/mtd/nand/jz4740_nand.c           |    1 -
 drivers/net/cpsw.c                       |    1 -
 drivers/net/npe/include/IxOsalOsIxp400.h |    2 +-
 drivers/spi/andes_spi.h                  |    4 +-
 drivers/spi/davinci_spi.h                |    4 +-
 drivers/usb/eth/Makefile                 |    1 +
 drivers/usb/eth/mcs7830.c                |  850 ++++++++++++++++++++++++++++++
 drivers/usb/eth/usb_ether.c              |    7 +
 include/common.h                         |    3 +
 include/configs/harmony.h                |    3 +-
 include/configs/m53evk.h                 |    1 +
 include/configs/mx53loco.h               |    1 +
 include/configs/nitrogen6x.h             |    1 +
 include/configs/omap3_beagle.h           |    3 +-
 include/configs/stamp9g20.h              |    5 +-
 include/usb_ether.h                      |   14 +-
 23 files changed, 903 insertions(+), 28 deletions(-)
 create mode 100644 drivers/usb/eth/mcs7830.c

-- 
1.7.10.4



More information about the U-Boot mailing list