[U-Boot] [RFC PATCH 1/3] add file with a default boot environment based heavily on Stephen Warrens recent tegra work.

[Dennis Gilmore]

On Wed, 19 Feb 2014 08:42:57 -0500
Tom Rini <trini at ti.com> wrote:

> On Mon, Feb 17, 2014 at 11:56:36AM -0600, Dennis Gilmore wrote:
> 
> > Signed-off-by: Dennis Gilmore <dennis at ausil.us>
> [snip]
> > +		"if ${usb_need_init}; then " \
> > +			"set usb_need_init false; " \
> > +			"usb start 0; " \
> 
> Checking common/cmd_usb.c, 'start' doesn't take arguments.

Copied from tegra-common-post.h as is, will fix it up

> > +#ifdef CONFIG_CMD_SATA
> > +#define BOOTCMDS_SATA \
> > +	"sata_boot=" \
> > +		"setenv devtype sata; " \
> > +		"if sata dev ${devnum}; then " \
> > +			"run scan_boot; " \
> > +		"fi\0" \
> > +	\
> > +	"bootcmd_sata0=setenv devnum 0; run sata_boot;\0"
> > +	"bootcmd_sata1=setenv devnum 1; run sata_boot;\0"
> > +#define BOOT_TARGETS_USB "sata0 sata1"
> 
> Typo, s/USB/SATA/

will fix

> > +#ifdef CONFIG_CMD_DHCP
> > +#define BOOTCMDS_DHCP \
> > +	"bootcmd_dhcp=" \
> > +		BOOTCMD_INIT_USB \
> 
> Why BOOTCMD_INIT_USB here?  For USB based networking?  If so, add some
> comments please.
It was Copied from tegra-common-post.h im assuming that it to support
booting from a usb attached nic

> > +		"if dhcp ${scriptaddr} boot.scr.uimg; then "\
> > +			"source ${scriptaddr}; " \
> > +		"fi\0"
> 
> This relies on autoload being true, so we should set that.
okay, will fix it up.

Thanks

Dennis