[U-Boot] [RFC PATCH 2/3] move the beaglebones over to the generic configs

[Dan Murphy]

On 02/19/2014 02:38 PM, Stephen Warren wrote:
> On 02/19/2014 01:31 PM, Dan Murphy wrote:
>> On 02/19/2014 02:22 PM, Stephen Warren wrote:
>>> On 02/19/2014 01:20 PM, Dan Murphy wrote:
>>>> On 02/19/2014 02:05 PM, Stephen Warren wrote:
>>>>> On 02/19/2014 12:57 PM, Dan Murphy wrote:
>>>>>> On 02/17/2014 11:56 AM, Dennis Gilmore wrote:
>>>>> ...
>>>>>>> +#ifndef CONFIG_SPL_BUILD
>>>>>>> +#include <config_distro_defaults.h>
>>>>>> I did not see the patchset for this.
>>>>>>
>>>>>> Should this header and the removal the extra configs be a different patch?
>>>>>> Or be part of the series that introduces the distro defaults
>>>>> The following is already in u-boot/master:
>>>>> 13a49c3a739b config: add config_distro_defaults.h
>>>>>
>>>>> I've sent patches to convert Tegra and RPi to use it, although they
>>>>> aren't applied yet.
>>>> Great! So why did this change come in as part of the RFC and not a patch for review and merge?
>>> Because it needed discussion/comments from the owners of the affected
>>> files perhaps?
>> Agreed to the discussion/comments.  But this change is not relevant to converting to a common boot right?
>> And it is kinda buried in this patch and might be over looked.
>> I guess the same can be said for the wandboard patch.
>>
>> IMHO These changes should be broken out, reviewed then they can be merged quicker if not part of this RFC.
> ??? The whole point of this series is to convert the 2 boards to use the
> two headers that define a standardized set of U-Boot options (the header
> for which has already been merged) and a standardized set of U-Boot
> scripts (the header for which is part of this patch series). Splitting
> them up makes no sense at all.

Hey it was just my opinion. (I just like functional changes broken out for bissectability when debugging issues)

But that is ultimately up to the maintainer to decide in the end.
I will attempt to review it when it comes in as an official patchset.


Dan

-- 
------------------
Dan Murphy