[U-Boot] [PATCH] socfpga: Add a signing tool that automatically signs the preloader.

[Charles Manning]

Hi Tom

On Thursday 20 February 2014 13:32:37 Tom Rini wrote:
> On Thu, Feb 20, 2014 at 12:01:40PM +1300, Charles Manning wrote:
> > No need to use the altera tool any more...
> >
> > Signed-off-by: Charles Manning <cdhmanning at gmail.com>
>
> [snip]
>
> > +	//crcval = crc_calc ((uint32_t *)buf, len/4);
> > +	printf("crc %x\n", crcval);
>
> Debug stuff left in?
>
> > +static char *out_filename = "";
> > +
> > +
> > +
> > +static void bad_exit(const char *str)
>
> Extra spaces.

Thanks for the feedback.

I will fix those and resubmit.

>
> Finally, we can't do this as an extension of mkimage?  We do other
> headers with that already, does it really not fit that model?  Thanks!

I looked at doing a mkimage integration, but is this really the way to go in 
all cases?

The signed image does not really apply a header as such. It mashes in 
a "header" at position 0x40 and then appends a checksum at the end, then pads 
the file out to 64k.

The final file is:
* 64 bytes of executable (interrupt vector table)
* "header"
* more code
*crc32
*padding with 0x00 to 64k.

Adding it to mkimage and "cooking" the binary was not too hard. I could not 
figure out how to extend the size of the buffer and pad it out to 64k. I'm 
sure I could figure that out... it's just software..

If it really **must** be part of mkimage, I'll do that.

If so, what mkimage operation need to be supported? 

Changing type makes no sense (apart from signing a binary). There are no 
uboot-format header/marker or anything. Verification probably makes sense, 
but that's it.

Thoughts??

-- Charles