[U-Boot] [PATCH] ENGR00299356 ARM:imx6 Fix USDHC driver bug in PIO mode

[Ye Li]

Thanks, I will change the commit log accordingly.

Best regards,
Ye Li
-----Original Message-----
From: Stefano Babic [mailto:sbabic at denx.de] 
Sent: Wednesday, February 19, 2014 9:41 PM
To: Li Ye-B37916; sbabic at denx.de; Estevam Fabio-R49496
Cc: u-boot at lists.denx.de; Albert ARIBAUD
Subject: Re: [PATCH] ENGR00299356 ARM:imx6 Fix USDHC driver bug in PIO mode

Hi Ye.Li,

On 19/02/2014 11:33, Ye.Li wrote:
> When configure the USDHC driver to PIO mode by defining 
> "CONFIG_SYS_FSL_ESDHC_USE_PIO", the SD/MMC read and write will fail.
> 
> Two bugs in the driver to cause the issue:
> 1. The read buffer was invalidated after reading from DATAPORT 
> register, which should be only applied to DMA mode. The valid data in 
> cache was overwritten by physical memory.
> 2. The watermarks are not set in PIO mode, will cause according state 
> not be set.
> 
> Signed-off-by: Ye.Li <B37916 at freescale.com>
> ---

Why is this an  ARM/i.MX6 issue only ? As far as I read, this is not strictly related to the SOC. Currently, there is no ARM boards setting CONFIG_SYS_FSL_ESDHC_USE_PIO. The only boards using it are PowerPC boards (the driver is platform independent): P1_P2_RDB and MPC8308RDB.

Regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================