[U-Boot] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine

[Scott Wood]

On Thu, 2014-02-20 at 13:52 +0100, Alexander Graf wrote:
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c
> index 3e99b07..51f2085 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu.c
> @@ -272,6 +272,7 @@ int do_reset (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  #ifndef CONFIG_SYS_FSL_TBCLK_DIV
>  #define CONFIG_SYS_FSL_TBCLK_DIV 8
>  #endif
> +__attribute__((weak))
>  unsigned long get_tbclk (void)
>  {
>  	unsigned long tbclk_div = CONFIG_SYS_FSL_TBCLK_DIV;

It's not a big deal, but we do have __weak available.

> +static void map_fdt_as(int esel)
> +{
> +	u32 mas0, mas1, mas2, mas3, mas7;
> +	uint64_t fdt_phys = get_fdt_phys();
> +	unsigned long fdt_phys_tlb = fdt_phys & ~0xffffful;
> +	unsigned long fdt_virt_tlb = (ulong)get_fdt_virt() & ~0xffffful;
> +
> +	mas0 = MAS0_TLBSEL(1) | MAS0_ESEL(10);

Shouldn't you use the esel parameter here?

-Scott