[U-Boot] [PATCH V2 05/12] board:samsung:common: remove unused max77686 init function

[Piotr Wilczek]

Dear Minkyu Kang,

> -----Original Message-----
> From: Minkyu Kang [mailto:mk7.kang at samsung.com]
> Sent: Saturday, February 22, 2014 8:38 AM
> To: Rajeshwari Birje; Piotr Wilczek; Rajeshwari S Shinde
> Cc: Jaehoon Chung; u-boot at lists.denx.de; Kyungmin Park
> Subject: Re: [U-Boot] [PATCH V2 05/12] board:samsung:common: remove
> unused max77686 init function
> 
> Dear Rajeshwari and Piotr,
> 
> On 14/02/14 20:40, Rajeshwari Birje wrote:
> > Hi Piotr,
> >
> > On Fri, Feb 14, 2014 at 3:18 PM, Piotr Wilczek
> <p.wilczek at samsung.com> wrote:
> >> Hi Rajeshwari,
> >>
> >>> -----Original Message-----
> >>> From: Rajeshwari Birje [mailto:rajeshwari.birje at gmail.com]
> >>> Sent: Friday, February 14, 2014 6:32 AM
> >>> To: Piotr Wilczek
> >>> Cc: u-boot at lists.denx.de; Jaehoon Chung; Kyungmin Park; Rajeshwari
> S
> >>> Shinde
> >>> Subject: Re: [U-Boot] [PATCH V2 05/12] board:samsung:common: remove
> >>> unused max77686 init function
> >>>
> >>> Hi Piotr,
> >>>
> >>> On Thu, Feb 13, 2014 at 7:40 PM, Piotr Wilczek
> >>> <p.wilczek at samsung.com>
> >>> wrote:
> >>>> This patch removes currently unused max77686_init function.
> >>>> Despite being not used, it's implementation is board specific.
> >>>>
> >>> MAX77686 is required for 5250, but missed it somehow when adding
> >>> 5420 support and making a common config file for both. It is my
> >>> mistake will correct the same You can refer:
> >>> "[U-Boot] [PATCH V5 0/6] SMDK5420: Add S2MPS11 pmic support to
> >>> SMDK5420" by Leela Krishna Amudala It adds a generic way for PMIC
> >>> support.
> >>> http://lists.denx.de/pipermail/u-boot/2014-January/171113.html
> >>>
> >> MAX77686 is also used at Trats2 so max77686_init must be either
> >> generic based on DT or moved to the board file.
> >
> > Generic in the sense you want all registers to be set and there
> values
> > have to come from DT file?
> > Which ever you feel OK is fine with me.
> >
> 
> So.. do you agree to apply this patch?
> or need another discussion?
> 
I will move max77686_init to smdk5250 board file and prepare v3 of this
patch series.
Do you have any other comments to this series?

> Thanks,
> Minkyu Kang.

Best regards,
Piotr Wilczek