[U-Boot] [PATCH V2] cfb_console: force natural alignment of 32-bit fields in gzipped .bmp files

[Wolfgang Denk]

Dear Eric Nelson,

your message contains no thread information - there is neither a
In-reply-to: nor any References: header.  This is bad!

Please also make sure to keep the Subject: test short; the recommended
style for the commit message is "50/72 formatting", i. e. the Subject
should not exceed 50 (...60) characters.

In message <1393621572-10306-1-git-send-email-eric.nelson at boundarydevices.com> you wrote:
> .bmp files contain 32-bit integers aligned at offsets of +2, +6,
> et cetera within the bmp_header structure (see include/bmp_layout.h).
> 
> Support for gzip-compressed .bmp files is present in the cfb_console
> display subsystem by uncompressing them prior to use.
> 
> This patch forces the in-memory header to be aligned properly
> for these compressed images by extracting them to a 2-byte
> offset in the memory returned by malloc. Since malloc will always
> return a 4-byte aligned value, this forces the .bmp header
> fields to be naturally aligned on 4-byte addresses.
> 
> Refer to these files for more details:
> 	doc/README.displaying-bmps
> 	doc/README.arm-unaligned-accesses
> 
> Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
> ---
>  drivers/video/cfb_console.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

So what exactly has changed since version 1?  Please note that the
change log is mandatory!

> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index 6db4073..2209148 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
> @@ -1473,7 +1473,10 @@ int video_display_bitmap(ulong bmp_image, int x, int y)
>  			printf("Error: malloc in gunzip failed!\n");
>  			return 1;
>  		}
> -		if (gunzip(dst, CONFIG_SYS_VIDEO_LOGO_MAX_SIZE,
> +		/* NB: we need to force offset of +2
> +		 * See doc/README.displaying-bmps
> +		 */

Incorrect multiline comment style, please fix.

I asked you before to fix that, please make sure not to ignore
review comments!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
G's Third Law:             In spite of all evidence  to  the  contra-
ry,  the  entire  universe  is composed of only two basic substances:
magic and bullshit.
H's Dictum:                There is no magic ...