[U-Boot] [PATCH v2 01/13] s5p: gpio: change gpio coding method for s5p gpio.

Przemyslaw Marczak p.marczak at samsung.com
Thu Jan 2 08:55:39 CET 2014


Hello Minkyu,

On 01/02/2014 07:35 AM, Minkyu Kang wrote:
> Hi,
>
> On 19/12/13 03:31, Przemyslaw Marczak wrote:
>> Old s5p gpio coding method was not clean and was not working properly
>> for all parts and banks. New method is clean and easy to extend.
>>
>> Gpio coding mask:
>> 0x000000ff - pin number
>> 0x00ffff00 - bank offset
>> 0xff000000 - part number
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> ---
>>   arch/arm/include/asm/arch-exynos/gpio.h  |  169 +++++++++++-------------------
>>   arch/arm/include/asm/arch-s5pc1xx/gpio.h |   47 +++++++--
>>   drivers/gpio/s5p_gpio.c                  |   15 +--
>>   include/configs/s5p_goni.h               |    4 +-
>>   include/configs/s5pc210_universal.h      |   12 +--
>>   include/configs/trats.h                  |    8 +-
>>   include/configs/trats2.h                 |   12 +--
>>   7 files changed, 125 insertions(+), 142 deletions(-)
>>
>
> patch failed.
>
> $ patch --dry-run -p1 < U-Boot-v2-01-13-s5p-gpio-change-gpio-coding-method-for-s5p-gpio..patch
> patching file arch/arm/include/asm/arch-exynos/gpio.h
> Hunk #1 FAILED at 196.
> 1 out of 1 hunk FAILED -- saving rejects to file arch/arm/include/asm/arch-exynos/gpio.h.rej
> patching file arch/arm/include/asm/arch-s5pc1xx/gpio.h
> patching file drivers/gpio/s5p_gpio.c
> patching file include/configs/s5p_goni.h
> patching file include/configs/s5pc210_universal.h
> patching file include/configs/trats.h
> Hunk #1 FAILED at 283.
> 1 out of 1 hunk FAILED -- saving rejects to file include/configs/trats.h.rej
> patching file include/configs/trats2.h
> Hunk #1 FAILED at 293.
> 1 out of 1 hunk FAILED -- saving rejects to file include/configs/trats2.h.rej
>
> please check it.
>
> Thanks,
> Minkyu Kang.
>
>

Thank you for reply. Probably there were some changes in tree since I 
had sent this patch set. I will check this.

Regards
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list