[U-Boot] [PATCH v2 2/6] titanium: Return from cpu_eth_init() directly

Fabio Estevam festevam at gmail.com
Sat Jan 4 20:36:29 CET 2014


From: Fabio Estevam <fabio.estevam at freescale.com>

There is no need to print an error message when cpu_eth_init() fails because
net/eth.c already prints it.

In order to simplify the code, just return the value from cpu_eth_init(bis)
directly.

Cc: Stefan Roese <sr at denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
---
 board/barco/titanium/titanium.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/board/barco/titanium/titanium.c b/board/barco/titanium/titanium.c
index 6db4488..84a7b84 100644
--- a/board/barco/titanium/titanium.c
+++ b/board/barco/titanium/titanium.c
@@ -264,15 +264,9 @@ int board_phy_config(struct phy_device *phydev)
 
 int board_eth_init(bd_t *bis)
 {
-	int ret;
-
 	setup_iomux_enet();
 
-	ret = cpu_eth_init(bis);
-	if (ret)
-		printf("FEC MXC: %s:failed\n", __func__);
-
-	return ret;
+	return cpu_eth_init(bis);
 }
 
 int board_early_init_f(void)
-- 
1.8.1.2



More information about the U-Boot mailing list