[U-Boot] [PATCH 5/6] sh: sh4: Add CONFIG_SH4 definition to config.mk of SH4

[Masahiro Yamada]

Hi Nobuhiro.


> diff --git a/arch/sh/cpu/sh4/config.mk b/arch/sh/cpu/sh4/config.mk
> index c357557..753580b 100644
> --- a/arch/sh/cpu/sh4/config.mk
> +++ b/arch/sh/cpu/sh4/config.mk
> @@ -8,5 +8,5 @@
>  # SPDX-License-Identifier:	GPL-2.0+
>  #
>  #
> -PLATFORM_CPPFLAGS += -m4-nofpu
> +PLATFORM_CPPFLAGS += -DCONFIG_SH4 -m4-nofpu
>  PLATFORM_RELFLAGS += -ffixed-r13

Basically it looks good to me.
But I have some comments.

Before this patch series,
    include/configs/r7780mp.h
    include/configs/sh7752evb.h
    include/configs/sh7753evb.h
    include/configs/sh7757lcr.h
    include/configs/sh7785lcr.h
defined not CONFIG_SH4, but CONFIG_SH4A.

Now you are adding "CONFIG_SH4" to them too.

If we do not have to distinguish SH4A from SH4,
can we delete "CONFIG_SH4A"?

It looks like we can re-write
#if defined(CONFIG_SH4) || defined(CONFIG_SH4A)
as
#if defined(CONFIG_SH4)

in /arch/sh/include/asm/cache.h and /include/sh_tmu.h


Best Regards
Masahiro Yamada