[U-Boot] [PATCH] net: execute "miiphy_init" if CONFIG_PHYLIB defined

Alexey Brodkin Alexey.Brodkin at synopsys.com
Fri Jan 10 16:58:11 CET 2014


In "common/Makefile" "miiphyutil.o" gets built if any of the following
items enabled:
 * CONFIG_PHYLIB
 * CONFIG_MII
 * CONFIG_CMD_MII

So it's possible to not define CONFIG_MII or CONFIG_CMD_MII and still
use functions like "miiphy_get_dev_by_name".

In its turn "miiphy_get_dev_by_name" traverses "mii_devs" list which is
not initialized because "miiphy_init" never got called.

Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>

Cc: Joe Hershberger <joe.hershberger at ni.com>
Cc: Rob Herring <rob.herring at calxeda.com>
Cc: Simon Glass <sjg at chromium.org>
Cc: Wolfgang Denk <wd at denx.de>
---
 net/eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/eth.c b/net/eth.c
index c96e767..32bd10c 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -279,7 +279,7 @@ int eth_initialize(bd_t *bis)
 	eth_current = NULL;
 
 	bootstage_mark(BOOTSTAGE_ID_NET_ETH_START);
-#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
+#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) || defined(CONFIG_PHYLIB)
 	miiphy_init();
 #endif
 
-- 
1.8.4.2



More information about the U-Boot mailing list