[U-Boot] [PATCH v7 00/17] sf: Add support for quad and dual_flash

Gerhard Sittig gsi at denx.de
Mon Jan 13 10:45:55 CET 2014


On Sun, Jan 12, 2014 at 22:29 +0530, Jagannadha Sutradharudu Teki wrote:
> 
> This series is a combo of quad cmds and dual_flash support
> Refer [1] and [2] for more functional description about this changes.
> 
> [ ... ]
> 
> Please let me know for any issues/concerns/questions.
> 
> -- 
> Thanks,
> Jagan. 
> 
> Changes for v7:
> 	- cmdsz on read_ops
> 	- sf param flags are placed spi_flash.h
> 	- code cleanup
> 	- updated dual_flash with BAR support
> [ ... ]

Mail setup related nits:

Please don't do this.  The dash line correctly separates your
signature, which is good (and not a given either).  But putting
more context below that line will make it look like it's part of
the signature, and thus probably will get lost (either by
automatic trimming, or folding, or colorization and/or mental
filtering).

Then I noticed that the series and your cover letter aren't
"connected".  The series should be a reply to the cover letter,
while you seem to create and send them out in separate steps.
Which breaks their relation, and has them appear in random order
and with other messages in between them.

And the recipient list suggests that there is an issue with
inappropriately quoted entries, there's another nonexistent
@theia address as has been in the past.  Please fix this (I did
upon reply, check your original message).


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list