[U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init()

[Michael Trimarchi]

Hi

On Mon, Jan 13, 2014 at 3:39 PM, Mateusz Zalega <m.zalega at samsung.com> wrote:
> On 01/10/14 06:08, Jaehoon Chung wrote:
>>> index dc155ad..0d8f30d 100644
>>> --- a/board/samsung/common/ums.c
>>> +++ b/board/samsung/common/ums.c
>>> @@ -37,6 +37,9 @@ static struct ums ums_dev = {
>>>
>>>  static struct ums *ums_disk_init(struct mmc *mmc)
>>>  {
>>> +    if (mmc_init(mmc))
>>> +            return NULL;
>>> +
>>>      uint64_t mmc_end_sector = mmc->capacity / SECTOR_SIZE;
>>>      uint64_t ums_end_sector = UMS_NUM_SECTORS + UMS_START_SECTOR;
>>
>> -->   if (mmc_init(mmc))
>>               return NULL;
>>
>> Locate this point.
>
> If you're asking to put this if() block after variable declaration, NAK.
>

I don't understand your point

> It's perfectly fine C99 code. I'm not aware of any existing U-Boot style
> guidelines that would forbid me to leave it this way.
>
> These variables are only meaningful when mmc_init() returns a valid pointer.
>

http://www.denx.de/wiki/U-Boot/CodingStyle

Michael

> Regards,
> --
> Mateusz Zalega
> Samsung R&D Institute Poland
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot