[U-Boot] [PATCH] powerpc:Rename CONFIG_PBLRCW_CONFIG & CONFIG_SYS_FSL_PBL_PBI

Scott Wood scottwood at freescale.com
Mon Jan 13 19:32:18 CET 2014


On Mon, 2014-01-13 at 14:48 +0100, Wolfgang Denk wrote:
> Dear Prabhakar,
> 
> In message <52D37CF5.2090100 at freescale.com> you wrote:
> > 
> > > What is the reason for the reenaming?  Especially, why changing from
> > > CONFIG_ to CONFIG_SYS_ ?
> > 
> > CONFIG_PBLRCW_CONFIG has 2 CONFIG. it is slightly confusing.
> > 
> > Reason for moving CONFIG_ to CONFIG_SYS:  These defines enables of 
> > adding RCW(power on reset configuration) and
> > PBI(pre boot loader commands) in u-boot image. These information will be 
> > used by SoC hardware for NAND, SD, SPI boot.
> > As these configuration will be used by SoC hardware. I thought of adding 
> > CONFIG_SYS.
> 
> CONFIG_ means stuff that can be freely adjusted by the end user to
> match his likings, like adding one command and removing another.
> CONFIG_SYS_ means stuff that is determined by the hardware
> configuration, i. e. that has to be adjusted according to specific
> properties to make U-Boot working on some hardware, and which can (or
> should) not be "adjusted" by the end user.
> 
> I don;t understand your intentions enough to say which applies here;
> IIRC at least PBI might be more of the CONFIG_ type.

I think they belong in CONFIG_SYS -- they can be adjusted to some extent
if you know what you're doing, but they are not general user knobs.  As
far as end users are concerned, they should use the PBI/PBL files that
match their hardware.  The PBI file will mainly contain errata
workarounds, and/or hardware initialization necessary for certain types
of non-NOR booting (the user knob in the latter case is elsewhere, to
tell U-Boot what boot source to target).

-Scott




More information about the U-Boot mailing list