[U-Boot] [PATCH] spi: sh_qspi: Add header file that defines the address of registers

Jagan Teki jagannadh.teki at gmail.com
Tue Jan 14 07:25:17 CET 2014


Hi Nobuhiro,

On Tue, Jan 14, 2014 at 5:42 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj at renesas.com> wrote:
> Hi,
>
> 2014/1/14 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>:
>> Hi, Jagan.
>>
>> 2014/1/9 Jagan Teki <jagannadh.teki at gmail.com>:
>>> Hi Nobuhiro,
>>>
>>> On Thu, Jan 9, 2014 at 9:49 AM, Nobuhiro Iwamatsu
>>> <nobuhiro.iwamatsu.yj at renesas.com> wrote:
>>>> Hi,
>>>>
>>>> This macro was changed by following patch.
>>>> http://patchwork.ozlabs.org/patch/307934/
>>> OK.
>>> I will pick this once Albert pop your PR.
>
> Or  there is also a path you take in this patch.
> This patch is set. If you are not taken at the same time, this will
> not be build.

OK. I will mark the reviewed-by tag on this patch so-that we can send
PR all together to Albert.
is it fine for you?

>
> Albert, do you  think about this?
>
> Best regards,
>   Nobuhiro
>>>
>>> Any more spi patches?
>>>
>>
>> I dont have SPI patches.
>> Thank you.
>>
>> Best regards,
>>   Nobuhiro
>>
>>>>
>>>> I should have been CC to you this.
>>>>
>>>> Best regards,
>>>>   Nobuhiro
>>>>
>>>> 2014/1/9 Jagan Teki <jagannadh.teki at gmail.com>:
>>>>> Hi Nobuhiro Iwamatsu,
>>>>>
>>>>> On Wed, Jan 8, 2014 at 6:46 AM, Nobuhiro Iwamatsu
>>>>> <nobuhiro.iwamatsu.yj at renesas.com> wrote:
>>>>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
>>>>>> ---
>>>>>>  drivers/spi/sh_qspi.c | 3 ++-
>>>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/spi/sh_qspi.c b/drivers/spi/sh_qspi.c
>>>>>> index edeb42d..77ede6b 100644
>>>>>> --- a/drivers/spi/sh_qspi.c
>>>>>> +++ b/drivers/spi/sh_qspi.c
>>>>>> @@ -10,6 +10,7 @@
>>>>>>  #include <common.h>
>>>>>>  #include <malloc.h>
>>>>>>  #include <spi.h>
>>>>>> +#include <asm/arch/rmobile.h>
>>>>>>  #include <asm/io.h>
>>>>>>
>>>>>>  /* SH QSPI register bit masks <REG>_<BIT> */
>>>>>> @@ -170,7 +171,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
>>>>>>                 return NULL;
>>>>>>         }
>>>>>>
>>>>>> -       ss->regs = (struct sh_qspi_regs *)CONFIG_SH_QSPI_BASE;
>>>>>> +       ss->regs = (struct sh_qspi_regs *)SH_QSPI_BASE;
>>>>>
>>>>> I really don't understand where you define this macro.
>>>>>

-- 
Thanks,
Jagan.


More information about the U-Boot mailing list