[U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform

[Piotr Wilczek]

Hi Przemyslaw,

> -----Original Message-----
> From: Przemyslaw Marczak [mailto:p.marczak at samsung.com]
> Sent: Tuesday, January 14, 2014 9:48 AM
> To: u-boot at lists.denx.de
> Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski
> Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables
> describing platform
> 
> Hello Piotr,
> 
> On 01/14/2014 08:59 AM, Piotr Wilczek wrote:
> > This patch adds variables describing platform (soc, board, vendor) to
> > default environment.
> >
> > Samsung's common misc imitialisation is enabled to provide additional
> > board information in envs.
> >
> > Signed-off-by: Piotr Wilczek <p.wilczek at samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> > Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> > ---
> >   include/configs/s5pc210_universal.h |    5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/include/configs/s5pc210_universal.h
> > b/include/configs/s5pc210_universal.h
> > index d9e4c56..5e5f8e0 100644
> > --- a/include/configs/s5pc210_universal.h
> > +++ b/include/configs/s5pc210_universal.h
> > @@ -124,6 +124,11 @@
> >   #define CONFIG_SYS_CONSOLE_INFO_QUIET
> >   #define CONFIG_SYS_CONSOLE_IS_IN_ENV
> >
> > +#define CONFIG_ENV_VARS_UBOOT_CONFIG
> > +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
> > +
> > +#define CONFIG_MISC_INIT_R
> > +
> 
> You depends on my patch set and here we have a conflict in universal,
> trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these
> three boards, so you can remove it from configs.
> 
Is the samsung/common/misc.c file reserved only for misc_init_r function?
I think that CONFIG_MISC_INIT_R is misleading.

> >   #define CONFIG_EXTRA_ENV_SETTINGS					\
> >   	"updateb=" \
> >   		"onenand erase 0x0 0x100000;" \
> >
> 
> Thank you,
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak at samsung.com

Best regards,
Piotr Wilczek