[U-Boot] [PATCH 5/7] board:samsung:universal: add env variables describing platform

[Przemyslaw Marczak]

Hello Piotr,

On 01/14/2014 01:33 PM, Piotr Wilczek wrote:
> Hi Przemyslaw,
>
>> -----Original Message-----
>> From: Przemyslaw Marczak [mailto:p.marczak at samsung.com]
>> Sent: Tuesday, January 14, 2014 11:10 AM
>> To: u-boot at lists.denx.de
>> Cc: Piotr Wilczek; 'Minkyu Kang'; 'Kyungmin Park'; Lukasz Majewski
>> Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables
>> describing platform
>>
>> Hello Piotr,
>>
>> On 01/14/2014 10:37 AM, Piotr Wilczek wrote:
>>> Hi Przemyslaw,
>>>
>>>> -----Original Message-----
>>>> From: Przemyslaw Marczak [mailto:p.marczak at samsung.com]
>>>> Sent: Tuesday, January 14, 2014 9:48 AM
>>>> To: u-boot at lists.denx.de
>>>> Cc: Piotr Wilczek; Minkyu Kang; Kyungmin Park; Lukasz Majewski
>>>> Subject: Re: [PATCH 5/7] board:samsung:universal: add env variables
>>>> describing platform
>>>>
>>>> Hello Piotr,
>>>>
>>>> On 01/14/2014 08:59 AM, Piotr Wilczek wrote:
>>>>> This patch adds variables describing platform (soc, board, vendor)
>>>>> to default environment.
>>>>>
>>>>> Samsung's common misc imitialisation is enabled to provide
>>>>> additional board information in envs.
>>>>>
>>>>> Signed-off-by: Piotr Wilczek <p.wilczek at samsung.com>
>>>>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>>>>> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
>>>>> ---
>>>>>     include/configs/s5pc210_universal.h |    5 +++++
>>>>>     1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/include/configs/s5pc210_universal.h
>>>>> b/include/configs/s5pc210_universal.h
>>>>> index d9e4c56..5e5f8e0 100644
>>>>> --- a/include/configs/s5pc210_universal.h
>>>>> +++ b/include/configs/s5pc210_universal.h
>>>>> @@ -124,6 +124,11 @@
>>>>>     #define CONFIG_SYS_CONSOLE_INFO_QUIET
>>>>>     #define CONFIG_SYS_CONSOLE_IS_IN_ENV
>>>>>
>>>>> +#define CONFIG_ENV_VARS_UBOOT_CONFIG #define
>>>>> +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
>>>>> +
>>>>> +#define CONFIG_MISC_INIT_R
>>>>> +
>>>>
>>>> You depends on my patch set and here we have a conflict in
>> universal,
>>>> trats and trats2. My patchset defines CONFIG_MISC_INIT_R for these
>>>> three boards, so you can remove it from configs.
>>>>
>>> Is the samsung/common/misc.c file reserved only for misc_init_r
>> function?
>>> I think that CONFIG_MISC_INIT_R is misleading.
>>>
>>
>> No, it isn't reserved. Misc_init_r function is for various things and
>> is called from board_init_r. In this function we can put any common
>> code for our vendor boards. So why do you think it is bad?
>>
> So the misc.c file is reserved for misc_init_r only. The file is only for
> CONFIG_MISC_INIT_R.

In this meaning - YES, will compile only for CONFIG_MISC....

> I thought that in misc.c we can put some common code not necessarily called
> form misc_init_r but say from borad_late_init. But ok. To add some common
> code for board_late_init I need to add another file.
>

That was in my first patch set. So maybe I remove the CONFIG_MISC_INIT_R 
dependency from Makefile.

>>>>>     #define CONFIG_EXTRA_ENV_SETTINGS
> \
>>>>>     	"updateb=" \
>>>>>     		"onenand erase 0x0 0x100000;" \
>>>>>
>>>>
>>>> Thank you,
>>>> --
>>>> Przemyslaw Marczak
>>>> Samsung R&D Institute Poland
>>>> Samsung Electronics
>>>> p.marczak at samsung.com
>>>
>>> Best regards,
>>> Piotr Wilczek
>>>
>>>
>>>
>>>
>>
>> Thank you,
>> --
>> Przemyslaw Marczak
>> Samsung R&D Institute Poland
>> Samsung Electronics
>> p.marczak at samsung.com
>
>
>

Thanks,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com