[U-Boot] [PATCH] DRA7: add ABB setup for MPU voltage domain

Tom Rini trini at ti.com
Tue Jan 14 20:06:07 CET 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/14/2014 01:27 PM, Nishanth Menon wrote:
> Patch adds modification to shared omap5 abb_setup() function, and 
> proper registers definitions needed for ABB setup sequence. ABB is 
> initialized for MPU voltage domain at OPP_NOM.
> 
> Signed-off-by: Nishanth Menon <nm at ti.com> ---
> 
> arch/arm/cpu/armv7/omap5/abb.c         |   13 ++++++++++--- 
> arch/arm/cpu/armv7/omap5/prcm-regs.c   |    8 ++++++++ 
> arch/arm/include/asm/arch-omap5/omap.h |    2 ++ 3 files changed,
> 20 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/omap5/abb.c
> b/arch/arm/cpu/armv7/omap5/abb.c index 31b6795..3bf8897 100644 ---
> a/arch/arm/cpu/armv7/omap5/abb.c +++
> b/arch/arm/cpu/armv7/omap5/abb.c @@ -28,18 +28,25 @@ s8
> abb_setup_ldovbb(u32 fuse, u32 ldovbb) { u32 vset; +	u32
> fuse_enable_mask = OMAP5_ABB_FUSE_ENABLE_MASK; +	u32 fuse_vset_mask
> = OMAP5_ABB_FUSE_VSET_MASK;

My only concern, which I know the answer to I think, is shouldn't we
just have no default values here, and case in the right one for
omap5/dra74x and then dra72x in the future, etc, etc.  But we don't
know enough really to know if future SoCs will need a different
statement here, so it's good enough for now.

Reviewed-by: Tom Rini <trini at ti.com>

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS1YqfAAoJENk4IS6UOR1WG6YP/3p2A28HH96gnagf/Rd64OKS
TpHF9bduHMyiu1BBSfoYuw2pWAhVrnTCTyhFRy6P+xFcU6+V7k+IK8D4CjOTdvvL
udgY5fm9tYBJvr8j3GRE5VLoBo/tXFkeKkEhhXh5tNJ0ag5KmKiHqF/0zWkJmj0Y
YRmKtrRudl29Ot2vX+zStg/0cdJm37e9/0VDMJnoM+Sc06jlc3MLulh2c+D23gkO
IxSdAFHVlFn2YHoxYlE6Vhys49op6Wr41QryxRoLvzSRoTj80oJq9+rMLWul2jpA
mjCsslUdOMGm7WaipcjulBTZvLV3Qz1XNgCwUdidBXrpQxhe2VmkTMGzyU49gAC+
QrT+wgXWTKpAIsvLIRZJQ9GJ3I9ZnDrHwRw4mbUX++ey5fwahR7DtafT2DgRxRwb
zLU0JpCBh2W98sTzNBfuGda3kYVDoNWu4nGZDB3H2wSn1r+dFNbQPmyWqAzMdFYa
aN9G+GeunOi0sU5W9pCXXMbjjA3Iq/SE0zUNqERPOoBusCrUpzo0u6n64iFGfq8i
r0EM6Lf5OxCyvqGdUbuDwe1D/fKceInqFglVuFppz87dRunTbU0gr5iGw29i5nkX
iSaSoaGHlOlJhF9x5lr2cyTpxdNO6SYsgjr6d57VP8KPs0BMosVQoQ9N+3Y4SwIa
S2gO/eIMTP9oA+3PcUPY
=v4DC
-----END PGP SIGNATURE-----


More information about the U-Boot mailing list