[U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation

Masahiro Yamada yamada.m at jp.panasonic.com
Wed Jan 15 09:41:27 CET 2014


Hello Wolfgang


>  Over time, support for more and more boards gets added to U-Boot -
>  while other board support code dies a silent death caused by
> -negligence in combination with ordinary bitrot.  Sometimes this goes
> +negligence in combination with ordinary bitrot.	 Sometimes this goes
>  by unnoticed, but often build errors will result.  If nobody cares any
>  more to resolve such problems, then the code is really dead and will
> -be removed from the U-Boot source tree.  The remainders rest in piece
> -in the imperishable depths of the git history.  This document tries to
> +be removed from the U-Boot source tree.	 The remainders rest in piece
> +in the imperishable depths of the git history.	This document tries to
>  maintain a list of such former fellows, so archeologists can check
>  easily if here is something they might want to dig for...

Why did you insert TABs here?



>  
> -Board            Arch        CPU            Commit      Removed     Last known maintainer/contact
> +Board		Arch	    CPU		    Commit	Removed	    Last known maintainer/contact
  <<snip>>
> +A3000		powerpc     mpc824x	    -		-
> +CU824		powerpc     mpc824x	    -		-	    Wolfgang Denk <wd at denx.de>
> +debris		powerpc     mpc824x	    -		-	    Sangmoon Kim <dogoil at etinsys.com>
> +eXalion		powerpc     mpc824x	    -		-	    Torsten Demke <torsten.demke at fci.com>


You are using TABs and SPACEs mixed-up.

"ARCH" field is aligned by TAB. There are TABs between A3000 and powerpc.
Whereas, "CPU" field is aligned by SPACE. There are some SPACEs between
powerpc and mpc824x.

If you do this refactoring, I'd like to request that only TABs are used
consistently.


And another thing , this series can not applied on the current
u-boot/master.
(I think Tom can resolve the conflict.)


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list