[U-Boot] [PATCH] board_r - fixup functions table after relocation

thomas.langer at lantiq.com thomas.langer at lantiq.com
Wed Jan 15 14:50:30 CET 2014


Alexey Brodkin wrote on 2014-01-15:
> On Wed, 2014-01-15 at 11:27 +0000, thomas.langer at lantiq.com wrote:
>> I think this is only required/possible for architectures which define
>> CONFIG_NEEDS_MANUAL_RELOC, others don't have "gd->reloc_off"
>> 
>>>  	if (initcall_run_list(init_sequence_r))
>>>  		hang();
> 
> Hi Thomas,
> 
> I think it's a generic item for all boards that use "common/board_r.c"
> and "common/board_f.c". I.e. have CONFIG_BOARD_EARLY_INIT_F and
> CONFIG_BOARD_EARLY_INIT_R defined.
> 
> I see that in "common/board_f.c" it is used for example in
> "setup_reloc()" and this function is executed regardless platform.
> 
Hello Alexey,

it seems that CONFIG_SYS_GENERIC_BOARD is not used by any architecture
without CONFIG_NEEDS_MANUAL_RELOC, so your patch is okay.

Sorry for the noise.

> Regards,
> Alexey

Best Regards,
Thomas
---
There are two hard things in computer science: cache invalidation, naming things, and off-by-one errors.
---




More information about the U-Boot mailing list