[U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Jan 16 01:50:05 CET 2014


Hello Wolfgang,


> > Why did you insert TABs here?
> 
> Because it requires less typing when adding new entries.

I do understand you want to use TABs for indentation.
But I don't understand why you want to use them in the
comment block. I think the part will not be changed often.
I'm talking about a TAB between
" U-Boot source tree." and "The remainders rest"

> -be removed from the U-Boot source tree.  The remainders rest in piece
> -in the imperishable depths of the git history.  This document tries to
> +be removed from the U-Boot source tree.	 The remainders rest in piece
> +in the imperishable depths of the git history.	This document tries to

I mean, here.





> > You are using TABs and SPACEs mixed-up.
> 
> Correct.  I decided to go for a minimal-invasive change that would not
> result in some very long lines.  So most columns are aligned by TAG,
> and two of them by TAB + 4 x SPACE.

Makes sense.

> > If you do this refactoring, I'd like to request that only TABs are used
> > consistently.
> 
> I can do this - but then, this will result in very long lines.  Do you
> prefer that?

No. Shorter lines are better.
You are right.
(But I a little afraid someone who does not understand "TAB + 4 SPACE"
rule might break the format.)


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list