[U-Boot] [PATCH 2/6] add a generic set of configs to enable Distros to more easier support u-boot based systems

[Stephen Warren]

On 12/17/2013 12:16 AM, Dennis Gilmore wrote:
> Signed-off-by: Dennis Gilmore <dennis at ausil.us>

Nit: A patch description might be useful; e.g. to describe that distros
need to know that the bootloader enables a common set of options they
can rely on, and this file is the definition of that set.

> diff --git a/include/common.h b/include/common.h

> +/* use generic distro config */
> +#ifdef DISTRO_DEFAULTS
> +#include <config_distro_default.h>
> +#endif

Can we wrap that in the following also:

+#ifdef DISTRO_DEFAULTS
+#ifndef CONFIG_SPL_BUILD
+#include <config_distro_default.h>
+#endif
+#endif

That way, this header won't bloat up the size of Tegra's SPL, which is
limited to ~16K. Or, would you expect that extra ifdef to be placed
around the #define DISTRO_DEFAULTS?

> diff --git a/include/config_distro_default.h b/include/config_distro_default.h

Bike-shed: At least for Tegra, the headers which define common config
options are in include/configs/tegra_*.h, just like the top-level board
config files. Would this be better as include/configs/distro_defaults.h?