[U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff

Marek Vasut marex at denx.de
Sat Jan 18 21:37:21 CET 2014


On Saturday, January 18, 2014 at 09:06:30 PM, Jagannadha Sutradharudu Teki 
wrote:
> - Used small names for dual_flash macros
> - Updated doc/SPI/README.dual-flash
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna at xilinx.com>
> Cc: Marek Vasut <marex at denx.de>

I agree with the documentation, but disagree with the rename. Please split the 
patch into multiple logical blocks so these can be reviewed separatelly. One 
would be the documentation, the next the rename and I also see some new #ifdef 
in the code, which would be a third block.

Best regards,
Marek Vasut


More information about the U-Boot mailing list