[U-Boot] [U-Boot, v1, 2/2] i2c: zynq: Add support for the second i2c controller

[Michal Simek]

On 01/17/2014 07:43 AM, Heiko Schocher wrote:
> Hello Michal,
> 
> Am 13.01.2014 09:23, schrieb Michal Simek:
>> On 01/13/2014 09:10 AM, Heiko Schocher wrote:
>>> Hello Michael,
>>>
>>> Am 13.01.2014 08:53, schrieb Michal Simek:
>>>> On 01/13/2014 08:32 AM, Heiko Schocher wrote:
>>>>> Hello Michel,
>>>>>
>>>>> Am 03.01.2014 10:45, schrieb Michal Simek:
>>>>>> From: Michael Burr<michael.burr at logicpd.com>
>>>>>>
>>>>>> Initialize the second i2c controller.
>>>>>>
>>>>>> Signed-off-by: Michael Burr<michael.burr at logicpd.com>
>>>>>> Signed-off-by: Michal Simek<michal.simek at xilinx.com>
>>>>>>
>>>>>> ---
>>>>>> Changes in v1:
>>>>>> - Based on original thread from Michael Burr
>>>>>>      http://lists.denx.de/pipermail/u-boot/2013-October/165017.html
>>>>>>      Heiko did some changes in this mainline patch
>>>>>>      "i2c, zynq: convert zynq i2c driver to new multibus/multiadapter framework"
>>>>>>      (sha1: 0bdffe71fddeaa46768a39305797e4512dee0f15)
>>>>>> - MS rebase on latest&greatest
>>>>>>
>>>>>>     drivers/i2c/zynq_i2c.c | 46 ++++++++++++++++++++++++++++------------------
>>>>>>     include/configs/zynq.h |  7 +++----
>>>>>>     2 files changed, 31 insertions(+), 22 deletions(-)
>>>>>
>>>>> I could not apply your patch on top of current tree
>>>>>
>>>>> commit 7f673c99c2d8d1aa21996c5b914f06d784b080ca
>>>>> Merge: 8401bfa 10a147b
>>>>> Author: Tom Rini<trini at ti.com>
>>>>> Date:   Fri Jan 10 10:56:00 2014 -0500
>>>>>
>>>>>       Merge branch 'master' of git://git.denx.de/u-boot-arm
>>>>>
>>>>> Problem is the change in "include/configs/zynq.h", as this file does
>>>>> not longer exist in mainline ... I think, your change should be done
>>>>> in "include/configs/zynq-common.h", right?
>>>>>
>>>>> Is it OK, if I fix this, or would you send a v2 (prefered, as I could
>>>>> not test this)?
>>>>
>>>> yes, zynq.h was renamed to zynq-common.h.
>>>> That will be great if you can fix it yourself.
>>>
>>> Done, see:
>>> http://git.denx.de/?p=u-boot/u-boot-i2c.git;a=commit;h=8e0b3c020057b3f7345b6696029a80eaf162e7f3
>>>
>>> Please test and give me feedback. If my fix is not perfect, please
>>> post a v2, thanks!
>>
>>
>> Looks good to me. We will test it and I will let you know if we see any problem.
> 
> Do you find some time for tests? I want to send a pull request for
> pending i2c patches (inclusive this patch).

Sorry for delay. I have retest it and I see that I have totally messed up
the first patch.
"i2c: zynq: Support for 0-length register address"

This is the origin patch.
http://lists.denx.de/pipermail/u-boot/2013-October/165019.html

Interesting is that I really don't know what I have tested before. :-(

Would it be possible to remove this patch. Feel free to remove both
I will resend them.

Sorry for troubles.
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140120/d23a40e7/attachment.pgp>