[U-Boot] [PATCH 3/6] sf: Renames on dual_flash stuff

[Jagan Teki]

On Mon, Jan 20, 2014 at 6:46 PM, Marek Vasut <marex at denx.de> wrote:
> On Saturday, January 18, 2014 at 09:49:11 PM, Jagan Teki wrote:
>> On Sun, Jan 19, 2014 at 2:07 AM, Marek Vasut <marex at denx.de> wrote:
>> > On Saturday, January 18, 2014 at 09:06:30 PM, Jagannadha Sutradharudu
>> > Teki
>> >
>> > wrote:
>> >> - Used small names for dual_flash macros
>> >> - Updated doc/SPI/README.dual-flash
>> >>
>> >> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna at xilinx.com>
>> >> Cc: Marek Vasut <marex at denx.de>
>> >
>> > I agree with the documentation, but disagree with the rename. Please
>> > split the patch into multiple logical blocks so these can be reviewed
>> > separatelly. One would be the documentation, the next the rename and I
>> > also see some new #ifdef in the code, which would be a third block.
>>
>> I don't think we need to separate here! as documentation got changed
>> because of rename of macros' and also new #ifdef is already added one
>> CONFIG_SF_DUAL_FLASH which is also dual_flash specific.
>
> I still see documentation fixes, renames and even newly added code. This really
> makes no sense to me to meld all these into a single patch.

Will be clear in next series for sure!

-- 
Thanks,
Jagan.