On Mon, Jan 20, 2014 at 12:40 PM, Jagan Teki <jagannadh.teki at gmail.com> wrote: >> Shouldn't you return -ENOMEM instead? > > Yes - we can but anyway ret is -1 by default. > and sf code doesn't use -ve macros' as of now. -1 is not an propriate return error value in this case. Regards, Fabio Estevam