[U-Boot] [RFC PATCH 1/2] common: Add new clk command

Gerhard Sittig gsi at denx.de
Wed Jan 22 20:44:34 CET 2014


On Wed, Jan 22, 2014 at 12:02 +0100, Michal Simek wrote:
> 
> --- /dev/null
> +++ b/common/cmd_clk.c
> @@ -0,0 +1,51 @@
> +/*
> + * Copyright (C) 2013 Xilinx, Inc.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +#include <common.h>
> +#include <command.h>
> +#include <clk.h>
> +
> +int __weak soc_clk_dump(void)
> +{
> +	puts("Not implemented\n");
> +	return 1;
> +}
> +
> +static int do_clk_dump(cmd_tbl_t *cmdtp, int flag, int argc,
> +		       char *const argv[])
> +{
> +	return soc_clk_dump();
> +}

Is there a specific reason to not pass on the remaining (not yet
consumed) command line arguments?  Future implementations may
want to take a clock item's name, or a clock group's name, or
options related to the format or verbosity of the dump, et al.


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list