[U-Boot] [PATCH V2 1/8] arm:exynos: add cpu revision

Wolfgang Denk wd at denx.de
Thu Jan 23 11:28:32 CET 2014


Dear Piotr Wilczek,

In message <1390402477-24340-2-git-send-email-p.wilczek at samsung.com> you wrote:
> This patch enables to read cpu revision on Exynos CPU.

Sorry,  you really need to refactor your patches.

In this commit you add references to "s5p_cpu_id":

> @@ -196,10 +198,12 @@ static inline void s5p_set_cpu_id(void)
>  	case 0x210:
>  		/* Exynos4210 EVT1 */
>  		s5p_cpu_id = 0x4210;
> +		s5p_cpu_rev = cpu_rev;
>  		break;
>  	case 0x412:
>  		/* Exynos4412 */
>  		s5p_cpu_id = 0x4412;
> +		s5p_cpu_rev = cpu_rev;
>  		break;
>  	case 0x520:
>  		/* Exynos5250 */

But this variable does not exist anywhere.  It is only added in the
next patch.  Adding this patch causes build breakage, i. e. your patch
series is not bisectable.

Please fix!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If that makes any sense to you, you have a big problem."
                                  -- C. Durance, Computer Science 234


More information about the U-Boot mailing list