[U-Boot] [PATCH V2 1/5] fs: fix generic save command implementation

Simon Glass sjg at chromium.org
Sun Jan 26 16:26:46 CET 2014


On 23 January 2014 12:56, Stephen Warren <swarren at wwwdotorg.org> wrote:

> From: Stephen Warren <swarren at nvidia.com>
>
> Fix a few issues with the generic "save" shell command, and fs_write()
> function.
>
> 1) fstypes[].write wasn't filled in for some file-systems, and isn't
>    checked when used, which could cause crashes/... if executing save
>    on e.g. fat/ext filesystems.
>
> 2) fs_write() requires the length argument to be non-zero, since it needs
>    to know exactly how many bytes to write. Adjust the comments and code
>    according to this.
>
> 3) fs_write() wasn't prototyped in <fs.h> like other generic functions;
>    other code should be able to call this directly rather than invoking
>    the "save" shell command.
>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>

Not sure about the change log for v2, but the patch looks good.

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list