[U-Boot] [PATCH 2/7] fdt: add "fdt sign" command

Wolfgang Denk wd at denx.de
Mon Jan 27 07:50:05 CET 2014


Dear Heiko,

In message <52E5FE93.2030306 at denx.de> you wrote:
> 
> >> +               cfg_noffset = fit_conf_get_node(working_fdt, NULL);
> >> +               if (!cfg_noffset)
> >> +                       return CMD_RET_FAILURE;
> >
> > May need to print an error here, since otherwise it won't be clear
> > what went wrong.
> 
> Hmm... fit_conf_get_node() prints a dedicated error message if debug is
                                                              ^^^^^^^^^^^
> activated... I thought this is enough ... ?
  ^^^^^^^^^

But in production versions (with debug NOT enabled) the user would
never know what went wrong?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's when they say 2 + 2 = 5 that I begin to argue."    - Eric Pepke


More information about the U-Boot mailing list