[U-Boot] [PATCH v3] arm: exynos: change to use clrbits macro instead of readl/writel function

Gerhard Sittig gsi at denx.de
Tue Jan 28 15:15:34 CET 2014


On Mon, Jan 27, 2014 at 09:14 +0900, Inha Song wrote:
> 
> Use setbits/clrbits macro instead of readl/writel function
> 
> Signed-off-by: Inha Song <ideal.song at samsung.com>

You make this look like a mechanical edit sweep, and keep
ignoring that it fixes a real bug where clock setup was operating
on random data, and don't pass this information to those who work
with your submission (maintainers and release engineers).

Can you please be bothered to accept and incorporate the feedback
that you get, and don't waste the time of those who spend this
time and effort?  Thank you!


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list