[U-Boot] [PATCH] initial support for pengwyn board

[Wolfgang Denk]

Dear Lothar Felten,

In message <1390992013-4277-1-git-send-email-lothar.felten at gmail.com> you wrote:
> Signed-off-by: Lothar Felten <lothar.felten at gmail.com>

First, you do not provide a commit message.  When adding support for a
new board, it makes sense to give some description what this boar dis,
who manufactures it, which peripherals of it are supported by his
port, etc.

Second, it appears this is actually version 2 of you patch.  But you
fail to mark this in the Subject, and there is no change log included.
Please see [1] for detailed instructions what is needed.

[1]
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions

> +void am33xx_spl_board_init(void)
> +{
> +	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
> +	/* interface and will output the following fixed voltages: */
> +	/* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */
> +	/* VLDO1=1V8 (IO) VLDO2=1V8(IO) */
> +	/* Vcore=1V1 is fixed, generated by TPS62231 */

Please use

	/*
	 * this style
	 * for all your
	 * multi-line
	 * comments only
	 */


> diff --git a/include/configs/pengwyn.h b/include/configs/pengwyn.h
> new file mode 100644
> index 0000000..7a41151
...
> +#define V_SCLK				(V_OSCK)
...
> +#define CONFIG_ENV_SIZE			(0x4000)

There is no need for braces around simple values.

> +/* SPL */
> +#define CONFIG_SPL_POWER_SUPPORT
> +#define CONFIG_SPL_YMODEM_SUPPORT
> +
> +
> +

A single blank line should be sufficient.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Defaults are wonderful, just like fire.
                  - Larry Wall in <1996Mar6.004121.27890 at netlabs.com>