[U-Boot] [PATCH v3 2/2] cosmetics: braces, comment and whitespace formatting Signed-off-by: Lothar Felten <lothar.felten at gmail.com>

[Wolfgang Denk]

Dear Lothar Felten,

In message <1391009943-8028-3-git-send-email-lothar.felten at gmail.com> you wrote:
> Signed-off-by: Lothar Felten <lothar.felten at gmail.com>
> ---
>  board/silica/pengwyn/board.c |   10 +++++-----
>  include/configs/pengwyn.h    |    6 ++----
>  2 files changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/board/silica/pengwyn/board.c b/board/silica/pengwyn/board.c
> index d5dbd3b..97d7de4 100644
> --- a/board/silica/pengwyn/board.c
> +++ b/board/silica/pengwyn/board.c
> @@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = {
>  
>  void am33xx_spl_board_init(void)
>  {
> -	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
> -	/* interface and will output the following fixed voltages: */
> -	/* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */
> -	/* VLDO1=1V8 (IO) VLDO2=1V8(IO) */
> -	/* Vcore=1V1 is fixed, generated by TPS62231 */
> +	/* The pengwyn board uses the TPS650250 PMIC  without I2C
> +	 * interface and will output the following fixed voltages:
> +	 * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu)
> +	 * VLDO1=1V8 (IO) VLDO2=1V8(IO)
> +	 * Vcore=1V1 is fixed, generated by TPS62231 */

This is still wrong.  Please see the example I gave in my previous
message, and/or read the Linux CodingStyle document.

Also, it does not make sense to first knowingly add bad code and then
fix it in a later patch of the same seirs - please squash your
patches.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream  things  that  never
were; and I say ``Why not?''
       - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1