[U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code

[Tom Rini]

On Mon, Jan 27, 2014 at 10:53:25AM -0800, Darwin Rambo wrote:

> The Kona architecture is present on a number of Broadcom mobile SoCs
> including the bcm281xx family of chips.
[snip]
> +int __weak clk_sdio_enable(void *base, u32 rate, u32 *actual_ratep)
> +{
> +	return 0;
> +}
> +int __weak clk_bsc_enable(void *base, u32 rate, u32 *actual_ratep)
> +{
> +	return 0;
> +}

Blank lines between functions please.

> diff --git a/arch/arm/cpu/armv7/kona-common/lowlevel_init.S b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
> new file mode 100644
> index 0000000..a03afcc
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
> @@ -0,0 +1,15 @@
> +/*****************************************************************************
> +*
> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
> +*
> +* SPDX-License-Identifier:      GPL-2.0+
> +*
> +*****************************************************************************/
> +
> +//#include <asm-offsets.h>
> +//#include <config.h>
> +//#include <linux/linkage.h>
> +
> +.globl lowlevel_init
> +lowlevel_init:
> +	mov	pc, lr

(a) no commented out include lines
(b) This is empty, which seems wrong.  I strongly suspect you want to
make use of arch/arm/cpu/armv7/lowlevel_init.S and have an s_init
function, ala omap*/tegra/rmobile/etc.

> diff --git a/arch/arm/cpu/armv7/kona-common/proc.c b/arch/arm/cpu/armv7/kona-common/proc.c
> new file mode 100644
> index 0000000..92fb39b
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/kona-common/proc.c
> @@ -0,0 +1,20 @@
> +/*****************************************************************************
> +*
> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
> +*
> +* SPDX-License-Identifier:      GPL-2.0+
> +*
> +*****************************************************************************/
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/kona-common/misc.h>
> +#include <asm/armv7.h>
> +
> +void do_proc_wfe(int forever)
> +{
> +	do {
> +		asm volatile ("wfe	@ wait for event\n");
> +		/*printf("wake up from wfe\n"); */

No commented out printf, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/6a70f2ed/attachment.pgp>