[U-Boot] [PATCH 1/4] Reactivate the tracing feature

[Masahiro Yamada]

Hi Simon,


On Thu,  5 Jun 2014 12:27:49 -0600
Simon Glass <sjg at chromium.org> wrote:

> This was lost sometime in the Kbuild conversion. Add it back.

Not lost.
It was moved to examples/Makefile.


Prior to Kbuild conversion,  config.mk was like this:

------------------>8----------------------
BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))

ifeq ($(findstring examples/,$(BCURDIR)),)
ifeq ($(CONFIG_SPL_BUILD),)
ifdef FTRACE
CFLAGS += -finstrument-functions -DFTRACE
endif
endif
endif
--------------------8<-------------------------


"-finstrument-functions -DFTRACE" was enabled
only under examples/ directory.
(Do you remember why?)

That's why I moved it to examples/Makefile
to keep the equivalent behavior.




> diff --git a/config.mk b/config.mk
> index 05864aa..0c45c09 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -46,6 +46,10 @@ ifdef	BOARD
>  sinclude $(srctree)/board/$(BOARDDIR)/config.mk	# include board specific rules
>  endif
>  
> +ifdef FTRACE
> +PLATFORM_CPPFLAGS += -finstrument-functions -DFTRACE
> +endif
> +
>  #########################################################################
>  
>  RELFLAGS := $(PLATFORM_RELFLAGS)


OK.
If you want to enable this flag over the whole source tree,
please remove it from examples/Makefile.


BTW, 
In the description of  commit  5c2aeac5ae,
you mentioned tracing feature is not supported by SPL.

But you are enabling FTRACE also on SPL in this patch.
Are you sure there is no bad impact on SPL?



Best Regards
Masahiro Yamada