[U-Boot] [PATCH 1/4] Reactivate the tracing feature

[Simon Glass]

Hi Masahiro,

On 10 June 2014 00:47, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
> On Thu,  5 Jun 2014 12:27:49 -0600
> Simon Glass <sjg at chromium.org> wrote:
>
>> This was lost sometime in the Kbuild conversion. Add it back.
>
> Not lost.
> It was moved to examples/Makefile.
>
>
> Prior to Kbuild conversion,  config.mk was like this:
>
> ------------------>8----------------------
> BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))
>
> ifeq ($(findstring examples/,$(BCURDIR)),)
> ifeq ($(CONFIG_SPL_BUILD),)
> ifdef FTRACE
> CFLAGS += -finstrument-functions -DFTRACE
> endif
> endif
> endif
> --------------------8<-------------------------
>
>
> "-finstrument-functions -DFTRACE" was enabled
> only under examples/ directory.
> (Do you remember why?)
>
> That's why I moved it to examples/Makefile
> to keep the equivalent behavior.

I don't think it is the same. In my code I was trying to make sure
there was NO tracing in example directory, and SPL. I think I should
go the same way, so will update my patch.

>
>
>
>
>> diff --git a/config.mk b/config.mk
>> index 05864aa..0c45c09 100644
>> --- a/config.mk
>> +++ b/config.mk
>> @@ -46,6 +46,10 @@ ifdef      BOARD
>>  sinclude $(srctree)/board/$(BOARDDIR)/config.mk      # include board specific rules
>>  endif
>>
>> +ifdef FTRACE
>> +PLATFORM_CPPFLAGS += -finstrument-functions -DFTRACE
>> +endif
>> +
>>  #########################################################################
>>
>>  RELFLAGS := $(PLATFORM_RELFLAGS)
>
>
> OK.
> If you want to enable this flag over the whole source tree,
> please remove it from examples/Makefile.

OK

>
>
> BTW,
> In the description of  commit  5c2aeac5ae,
> you mentioned tracing feature is not supported by SPL.
>
> But you are enabling FTRACE also on SPL in this patch.
> Are you sure there is no bad impact on SPL?

Yes I should remove this otherwise it will at best bloat the code for
SPL. I think it is probably best just to revert that part of the
Makefile.

Thanks for looking at this, saves me another patch...

Regards,
Simon