[U-Boot] [PATCH v6 1/2] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c

Tom Rini trini at ti.com
Wed Jun 18 23:09:36 CEST 2014


On Mon, Jun 16, 2014 at 09:58:39AM +0200, Heiko Schocher wrote:

> move fdtdec_get_int() out of lib/fdtdec.c into lib/fdtdec_common.c
> as this function is also used, if CONFIG_OF_CONTROL is not
> used. Poped up on the ids8313 board using signed FIT images,
> and activating CONFIG_SYS_GENERIC_BOARD. Without this patch
> it shows on boot:
[snip]
> diff --git a/lib/Makefile b/lib/Makefile
> index 377ab13..dd87ee2 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -23,6 +23,13 @@ obj-$(CONFIG_USB_TTY) += circbuf.o
>  obj-y += crc7.o
>  obj-y += crc8.o
>  obj-y += crc16.o
> +ifdef CONFIG_FIT
> +obj-y += fdtdec_common.o
> +else
> +ifdef CONFIG_OF_CONTROL
> +obj-y += fdtdec_common.o
> +endif
> +endif

OK, but why not:
obj-$(CONFIG_FIT) += fdtdec_common.o
obj-$(CONFIG_OF_CONTROL) += fdtdec_common.o

Since we filter out duplicates I would swear.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140618/6349754b/attachment.pgp>


More information about the U-Boot mailing list