[U-Boot] [PATCH v2] boards.cfg: move boards with invalid emails to Orphan

Albert ARIBAUD albert.u.boot at aribaud.net
Tue Mar 11 12:58:26 CET 2014


Hi Masahiro,

On Tue, 11 Mar 2014 20:31:37 +0900, Masahiro Yamada
<yamada.m at jp.panasonic.com> wrote:

> Hello Albert,
> 
> > > Besides, Orphan boards have been collected at the bottom of boards.cfg.
> > > (This is done when we run "tools/reformat.py")
> > > 
> > > Add separators to distinguish them from those which
> > > were moved to Orphan 6 months ago.
> > > I believe it will be helpful in future to find which boards are
> > > old enough to be removed from the code base.
> > 
> > Agreed up to and including the above. However, it seems you have not
> > applied tools/reformat.py as requested in the file header: after
> > I have applied your patch, running reformat.py led to some lines being
> > reorganized in boards.cfg.
> 
> Yes. It is intentinal.
> I think touching other boards is beyond the scope of this patch
> and obscures the purpose of this patch.
> 
> I leave it for a dedicated patch.
> I expect Fabio Estevam will periodically post patches
> like commit 0876703cf  and sort boards.cfg.

The whole point is that any modification to boards.cfg should go through
tools/reformat.py so that boards.cfg is always properly ordered.

There's a script to automate this, and a command is provided so that you
can run it just by copy-pasting it, precisely to make sure no effort is
required for keeping the list sorted.

So please do keep it sorted.

> Best Regards
> Masahiro Yamada

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list