[U-Boot] [PATCH v2] boards.cfg: move boards with invalid emails to Orphan

Tom Rini trini at ti.com
Tue Mar 11 13:26:41 CET 2014


On Tue, Mar 11, 2014 at 08:31:37PM +0900, Masahiro Yamada wrote:
> Hello Albert,
> 
> > > Besides, Orphan boards have been collected at the bottom of boards.cfg.
> > > (This is done when we run "tools/reformat.py")
> > > 
> > > Add separators to distinguish them from those which
> > > were moved to Orphan 6 months ago.
> > > I believe it will be helpful in future to find which boards are
> > > old enough to be removed from the code base.
> > 
> > Agreed up to and including the above. However, it seems you have not
> > applied tools/reformat.py as requested in the file header: after
> > I have applied your patch, running reformat.py led to some lines being
> > reorganized in boards.cfg.
> 
> Yes. It is intentinal.
> I think touching other boards is beyond the scope of this patch
> and obscures the purpose of this patch.

Yes, all of Masahiro's changes are correctly formatted within the file
(just confirmed that).  I'll do a follow-up reformat and apply on top as
it's a separate change, that does need doing, but isn't part of this.
Thanks guys!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140311/c53678c1/attachment.pgp>


More information about the U-Boot mailing list