[U-Boot] [PATCH 1/8] kmp204x: Add support for the unit LEDs

[Valentin Longchamp]

Hi York,

On 04/30/2014 07:04 PM, York Sun wrote:
> On 04/30/2014 06:01 AM, Valentin Longchamp wrote:
>> From: Stefan Bigler <stefan.bigler at keymile.com>
> 
> <snip>
> 
>> diff --git a/board/keymile/kmp204x/qrio.c b/board/keymile/kmp204x/qrio.c
>> index 49f9aa2..11949f4 100644
>> --- a/board/keymile/kmp204x/qrio.c
>> +++ b/board/keymile/kmp204x/qrio.c
>> @@ -144,3 +144,17 @@ void qrio_prstcfg(u8 bit, u8 mode)
>>  
>>  	out_be32(qrio_base + PRSTCFG_OFF, prstcfg);
>>  }
>> +
>> +#define CTRLH_OFF		0x02
>> +#define CTRLH_WRL_BOOT		0x01
>> +#define CTRLH_WRL_UNITRUN	0x02
>> +
>> +void qrio_set_leds(void)
>> +{
>> +	u8 ctrlh;
>> +	void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE;
> 
> Please insert a blank line here.

OK, that's correct. Do you want me to resend the whole series or are the first 2
patches with the additional blank line OK ?

> 
>> +	/* set UNIT LED to RED and BOOT LED to ON */
>> +	ctrlh = in_8(qrio_base + CTRLH_OFF);
>> +	ctrlh |= (CTRLH_WRL_BOOT | CTRLH_WRL_UNITRUN);
>> +	out_8(qrio_base + CTRLH_OFF, ctrlh);
>> +}
>>