[U-Boot] [PATCH 3/2] net/designware: reorder struct dw_eth_dev to pack more efficiently.

Marek Vasut marex at denx.de
Thu May 1 21:23:29 CEST 2014


On Thursday, May 01, 2014 at 09:01:58 PM, Ian Campbell wrote:
> The {tx,rx}_mac_descrtable fields are aligned to ARCH_DMA_MINALIGN, which
> could be 256 or even larger. That means there is a potentially huge hole
> in the struct before those fields, so move them to the front where they
> are better packed.
> 
> Moving them to the front also helps ensure that so long as dw_eth_dev is
> properly aligned (which it is since "net/designware: ensure device private
> data is DMA aligned.") the {tx,rx}_mac_descrtable will be too, or at least
> avoids having to worry too much about compiler specifics.
> 
> Signed-off-by: Ian Campbell <ijc at hellion.org.uk>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>

Acked-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list