[U-Boot] [PATCH v5 03/12] usb: dfu: fix boards wo USB cable detection

Lukasz Majewski l.majewski at samsung.com
Mon May 5 09:50:02 CEST 2014


Hi Mateusz,

> Former usb_cable_connected() patch broke compilation of boards which
> do not support this feature.
> 
> I've renamed usb_cable_connected() to g_dnl_usb_cable_connected() and
> added its default implementation to gadget downloader driver code.
> There's only one driver of this kind and it's unlikely there'll be
> another, so there's no point in keeping it in /common.
> 
> Previously this function was declared in usb.h. I've moved it, since
> it's more appropriate to keep it in g_dnl.h - usb.h seems to be
> intended for USB host implementation.
> 
> Existing code, confronted with default -EOPNOTSUPP return value,
> continues as if the cable was connected.
> 
> CONFIG_USB_CABLE_CHECK was removed.
> 
> Signed-off-by: Mateusz Zalega <m.zalega at samsung.com>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Marek Vasut <marex at denx.de>

Applied to u-boot-dfu. Thanks


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list