[U-Boot] [PATCH 04/12] spl: consolidate arch/arm/include/asm/arch-*/spl.h

[Stefano Babic]

Hi Tim,

On 30/04/2014 07:39, Masahiro Yamada wrote:
> Hi Tim,
> Cc : Stefano, Tom
> 
> On Mon, 28 Apr 2014 13:17:30 -0700
> Tim Harvey <tharvey at gateworks.com> wrote:
> 
>> From: Masahiro Yamada <yamada.m at jp.panasonic.com>
>>
>> arch/arm/include/asm/spl.h requires all SoCs to have
>> arch/arm/include/asm/arch-*/spl.h.
>>
>> But many of them just define BOOT_DEVICE_* macros.
>>
>> Those macros are used in the "switch (boot_device) { ... }"
>> statement in common/spl/spl.c.
>>
>> So they should not be archtecture specific, but be described as
>> a simpile enumeration.
>>
>> This commit merges most of arch/arm/include/asm/arch-*/spl.h
>> into arch/arm/include/asm/spl.h.
>>
>> With a little more effort, arch-zynq/spl.h and arch-socfpga/spl.h
>> will be merged, while I am not sure about OMAP and Exynos.
>>
>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>> Cc: Tom Rini <trini at ti.com>
>> Cc: Michal Simek <michal.simek at xilinx.com>
>> Cc: Andreas Biesmann <andreas.devel at googlemail.com>
>> Cc: Stephen Warren <swarren at nvidia.com>
>> Cc: Tom Warren <twarren at nvidia.com>
>> CC: Stefano Babic <sbabic at denx.de>
>> CC: Minkyu Kang <mk7.kang at samsung.com>
>> Cc: Dinh Nguyen <dinguyen at altera.com>
>> Acked-by: Andreas Biesmann <andreas.devel at googlemail.com>
>> Acked-by: Michal Simek <monstr at monstr.eu>
>> Acked-by: Stefano Babic <sbabic at denx.de>
>> Acked-by: Stephen Warren <swarren at nvidia.com>
>> Acked-by: Tim Harvey <tharvey at gateworks.com>
>> Tested-by: Bo Shen <voice.shen at atmel.com> [on sama5d3xek board for at91 part]
>> Acked-by: Stephen Warren <swarren at nvidia.com>
>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> 
> I understand my patch is here because your series uses
> it as a prerequisite.
> 
> But, please make sure this patch should be reviewed and
> applied by Tom Rini because this patch is relevant to
> various SoCs.
> 

Indeed. Tim, it is enough you add in the cover letter for the next
version that your patchset depends on Masahiro's patch, without
including it in your series. I will check by merging if all dependencies
will be satisfied.

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================